search

electrode-io / electrode-static-paths

Electrode server decor to serve static files
Other
55 stars 10 forks source link

Update Minimum Lodash Version #5

Closed ammuench closed 6 years ago

ammuench commented 6 years ago

Update lodash version in package.json to accept a minimum of ^4.14.0.

This fixes an error where 4.13.1 was missing the defaultTo script, which could cause errors

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

jchip commented 6 years ago

^4.5.1 should pulled in 4.14.0. Did you get 4.13.1?

ammuench commented 6 years ago

The reasoning here is that if a parent package has a dep of 4.13.1, then this repo will use that version (that's what caused my issue). This is just a safeguard to ensure that even if the parent has the dep locked at 4.13.1 that this package will still pull 4.14.0 or later, which don't have the missing defaultTo.js issue