electrode-io / electrode

Web applications with node.js and React
Other
2.1k stars 301 forks source link

convert webpack config composer to be Typescript #1847

Closed zenz34 closed 3 years ago

zenz34 commented 3 years ago

convert webpack config to be Typescript

---------------------------- --------- ---------- --------- --------- ------------------- File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 100 100 100 100
concat-method.ts 100 100 100 100
constants.ts 100 100 100 100
delete-custom-props.ts 100 100 100 100
head-concat-array-merge.ts 100 100 100 100
index.ts 100 100 100 100
partial.ts 100 100 100 100
profile.ts 100 100 100 100
tail-concat-array-merge.ts 100 100 100 100
---------------------------- --------- ---------- --------- --------- -------------------

=============================== Coverage summary =============================== Statements : 100% ( 152/152 ) Branches : 100% ( 87/87 ) Functions : 100% ( 47/47 ) Lines : 100% ( 147/147 )

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jchip commented 3 years ago

unit test for xarc-webpack failed

Error: src/index.ts(295,24): error TS2351: This expression is not constructable.
  Type 'typeof import("/home/runner/work/electrode/electrode/packages/xarc-webpack/node_modules/.f/_/webpack-config-composer/1.1.3-fynlocal_h/webpack-config-composer/dist/index")' has no construct signatures.