electrode-io / electrode

Web applications with node.js and React
Other
2.1k stars 300 forks source link

[1.0.50][feat] non-root redux subapp support #1850

Open gaganjakhotiya opened 3 years ago

gaganjakhotiya commented 3 years ago

This change is to support a similar use-case as loadSubApp does here. If a reduxSubApp needs to be rendered within a composite component we won't be getting the DOM element to render the subapp in.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

jchip commented 3 years ago

Thanks for the PR. Can you provide some explanation on the context and use case for the change please?

gaganjakhotiya commented 3 years ago

This is to support a similar use-case as loadSubApp does here. If a reduxSubApp needs to be rendered within a composite component we won't be getting the DOM element to render the subapp in.