search

electrode-io / electrode

Web applications with node.js and React
Other
2.1k stars 300 forks source link

Fix : Replace request package with node-fetch in subapp-web #1981

Closed shubham2811 closed 1 year ago

shubham2811 commented 1 year ago

Request package is out of support https://www.npmjs.com/package/request and giving snyk vulnerability.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: shubham2811
:x: Shubham sharma

Shubham sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

arunvishnun commented 1 year ago

Hi @shubham2811 Thanks for taking care of this. Code changes look good to me. This PR may require rush change files to make a patch/minor release - rush change -v --target-branch upstream/master