search

electrode-io / electrode

Web applications with node.js and React
Other
2.1k stars 301 forks source link

Downgrade jsdom to v21 for backward node version compatibility #2002

Closed shubham2811 closed 8 months ago

shubham2811 commented 8 months ago

jsom v23(latest as of now) require minimum node 18 version which is breaking ci tests in case of node v14.So downgrading it to v21

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: shubham2811
:x: Shubham sharma

Shubham sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

shubham2811 commented 8 months ago

Dropping node 14 support.Hence closing PR