electrolux-oss / infrawallet

Backstage plugin that controls your cloud costs just in the way how you control your bank accounts
https://demo.infrawallet.io
Apache License 2.0
55 stars 4 forks source link

Add support for AWS authentication without assuming a role #102

Closed elisiariocouto closed 2 days ago

elisiariocouto commented 3 days ago

This PR makes the assumedRoleName optional and adds a configuration parameter for the AWS region.

If no assumedRoleName, accessKeyId and accessKeySecret are provided, the AWS Client will be used with no authentication configuration, which in turn will follow the AWS SDK default credential loader.

Related to #98

emillg commented 3 days ago

@elisiariocouto Thanks for your contribution!

Can you explain why you want to set the region other than us-east-1? Because for IAM, region doesn't matter much, and for Cost, it's using us-east-1: https://docs.aws.amazon.com/general/latest/gr/billing.html

elisiariocouto commented 3 days ago

You're right @emillg, just pushed a new commit that removes the region parameter.

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud