electron-archive / brightray_example

An example application using Brightray
MIT License
27 stars 15 forks source link

Fix building errors #23

Closed spolu closed 10 years ago

spolu commented 10 years ago

I still have linking errors you may help me with?

spolu@spolu-ThinkPad-T430s:~/src/brightray_example$ ./script/build 
  LINK(target) out/Debug/brightray_example
/usr/bin/ld: /home/spolu/src/brightray_example/vendor/brightray/vendor/download/libchromiumcontent/Release/libchromiumviews.a(gtk2ui.unity_service.o): undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [out/Debug/brightray_example] Error 1
Traceback (most recent call last):
  File "./script/build", line 43, in <module>
    sys.exit(main())
  File "./script/build", line 16, in main
    build()
  File "./script/build", line 33, in build
    subprocess.check_call(['make', '-j%d' % multiprocessing.cpu_count()])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-j4']' returned non-zero exit status 2
spolu@spolu-ThinkPad-T430s:~/src/brightray_example$ 
spolu commented 10 years ago

Actually works as is on less recent Ubuntu

aroben commented 10 years ago

Sounds like perhaps you're building against a too-new version of glibc? libchromiumcontent and brightray/brightray_example need to all be built against the same version AFAIK. /cc @zcbenz

spolu commented 10 years ago

Yes the error above is deinitely due to a mismatch in glibc. The fix is still required to properly build with the right glibc.

aroben commented 10 years ago

@spolu Does this PR actually fix the error? It doesn't seem like it changes anything about what version of glibc is used. Maybe I'm misunderstanding you?

spolu commented 10 years ago

This PR fixes a compilation error. And I still had some link issues on my machine but these were gone on a ubuntu 12.04 distribution. This PR is still required to properly compile the example :)

aroben commented 10 years ago

OK, thanks for the clarification. This PR looks good to me!

spolu commented 10 years ago

:+1: Sorry for the misunderstanding!