Update.exe does not have an icon

electron-archive / grunt-electron-installer

Grunt plugin to build Windows installers for Electron apps

MIT License

402 stars 106 forks source link

Update.exe does not have an icon #103

Closed MarshallOfSound closed 8 years ago

MarshallOfSound commented 8 years ago

Not sure what the expected behaviour is here, it's either

Update.exe takes the icon of the main application
Update.exe has it's own generic squirrel icon

But having an application with no icon looks quite bad (even for the few seconds it is visible for). Is it possible to use https://github.com/atom/node-rcedit to set the icon much like electron-packager does

anaisbetts commented 8 years ago

Set the setupIcon property

MarshallOfSound commented 8 years ago

@paulcbetts Sorry I don't think I communicated this clearly. My setupIcon is set correctly as seen here.

setup

But when installing for the briefest of moments, Update.exe appears in the task bar (maybe for like 2 - 3 seconds) without an icon.

update

scayssials commented 8 years ago

Same issue for me

anaisbetts commented 8 years ago

Oh yes - file a bug on squirrel/squirrel.windows. Also, where can I get this Google Play app?!?!

MarshallOfSound commented 8 years ago

@paulcbetts Will do thanks.

The player used to be WinForms based but the electron one is in a 3.0.0 branch here.
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/tree/dev/3.0.0

Unfortunately the update is blocked until the next chromium update inside electron happens :8ball: