Use electron-winstaller

electron-archive / grunt-electron-installer

Grunt plugin to build Windows installers for Electron apps

MIT License

398 stars 106 forks source link

Use electron-winstaller #104

Closed anaisbetts closed 8 years ago

anaisbetts commented 8 years ago

This PR moves us to use electron-winstaller instead of duplicating the code between the Grunt task and the library version

anaisbetts commented 8 years ago

I think this PR is correct but it looks like on Windows we're hitting a weirdo bug in electron-winstaller where jetpack takes the paths we give it and appends ./ to it

kevinsawicki commented 8 years ago

Went ahead and got this off CoffeeScript and a grunt-based build as well in this pull request, thanks for getting this going.

havenchyk commented 8 years ago

Hey @kevinsawicki! Is there anything else that should be done in this PR? I polished PR a little bit in the #107 on top of the current one.

anaisbetts commented 8 years ago

@kevinsawicki Once this build is :gem: this should finally be good to go, sorry this took forever

kevinsawicki commented 8 years ago

:+1:

kevinsawicki commented 8 years ago

Published as 2.0.0