search

electron-archive / grunt-electron-installer

Grunt plugin to build Windows installers for Electron apps
MIT License
402 stars 106 forks source link

Warning: Cannot read property 'description' of null Use --force to continue. #112

Closed Geeshang closed 8 years ago

Geeshang commented 8 years ago

I am using Grunt V1.0.1 and grunt-electron-installer V2.0.0, the build is failed with this Warning, and when add --force to grunt command ,there is nothing generated except "update.exe". Does it could be a bug?

havenchyk commented 8 years ago

it's a known issue. Please, check, is it the same? https://github.com/electron/windows-installer/issues/41

Geeshang commented 8 years ago

Seems this project is based on windows-installer, but electron/windows-installer#41 is still open right now, not solved.

havenchyk commented 8 years ago

@GeeshangXu yes, but 2.2.0 already released, probably. Could you please re-install grunt-electron-installer and check once again?

Added: well, we need to update it to the latest windows-installer.

Geeshang commented 8 years ago

@havenchyk Yes, this problem sovled by replace the old electron-winstaller V2.0.5 in grunt-electron-installer's node_modules with the latest version V2.2.0, thank you! But the the latest version 2.0.0 of grunt-electron-installer is still depend on the old electron-winstaller 2.0.5, so it need to be updated to fix the issue.

havenchyk commented 8 years ago

@GeeshangXu glad you solved your issue. Well, I haven't rights to merge pr's, maybe @kevinsawicki could provide them? I'll be glad to update to the latest version.

havenchyk commented 8 years ago

@GeeshangXu let's wait for new version, fix is already merged.

Geeshang commented 8 years ago

Good!