search

electron-archive / grunt-electron-installer

Grunt plugin to build Windows installers for Electron apps
MIT License
402 stars 106 forks source link

Can't change default atom-shell metadata icon #16

Closed bostondv closed 8 years ago

bostondv commented 9 years ago

When installing the generated setup file, an atom-shell .ico file is placed in ./AppData/Local/myapp/app.ico. This icon is displayed in add remove programs (and maybe other places?).

I can't find any way to change this.

Browsing the source I found the undocumented iconUrl option, it defaults to the atom-shell icon. However, this option in the gruntfile has no result on the installed .ico file. I've tried absolute, relative, and public web url values with no luck.

'create-windows-installer': {
      appDirectory: 'dist/windows/build',
      outputDirectory: 'dist/windows/installer',
      iconUrl: '../resources/windows/myapp.ico',
      setupIcon: '../resources/windows/myapp.ico',
      certificateFile: '../resources/windows/cert.p12',
      certificatePassword: 'xxxxxxxx',
      loadingGif: '../resources/windows/installer.gif'
}
rwhitmire commented 9 years ago

+1

anyone have any info on this? would be glad to submit a pull request if needed.

bostondv commented 9 years ago

It did end up working for me using a public web URL. But would be handy if this supported using a local icon file.

pracucci commented 9 years ago

If iconUrl is an https url it doesn't work to me (Windows 8.1, the SSL certificate is valid). If I switch to an http url it works.

gbmhunter commented 9 years ago

+1, can't get the icon to change.

havenchyk commented 8 years ago

IconUrl should an url to your icon. It's limitation of nuget, can't be fixed.