Closed bitomule closed 8 years ago
This is bugged at the moment, you'll have to build on Windows. We'll fix this up today
Thanks @paulcbetts . It requires .Net 4.5 even if I build it on window?
Same for installer built from Linux.
Hi @paulcbetts , do we have any updates for this issue? Seems the issue is caused by mono nuget, is it?
@meowlab This is fixed in master but I need to make a new build, I'll do it today
Thank you, so much!
Friendly Ping @paulcbetts
@paulcbetts is build published?
Not yet, folx are on vacation (I don't have permissions to publish new grunt-electron-installer releases), so it'll probably have to wait a week.
@paulcbetts So you mean the code now in repo is Okay? But I noticed all file under vendor
folder changes more than a month ago
@meowlab The code under Squirrel/Squirrel.Windows is Okay, but I need to build it and drop it into this repo, then we need to publish a release. If you want to build Squirrel.Windows yourself and drop it in you can, the command is
msbuild /p:Configuration=Release
Then look for the files in src\[Setup, Update]\bin\Release
@paulcbetts Thanks!! I will try it
@meowlab did you try it?
@bitomule Yeah, it works
Just compile it on a Windows computer, find all files under vendor
, replace them and then it can works fine
@meowlab thanks! I don't have windows so I'll have to run a vm. How is the official build going @paulcbetts? Are folks back from holidays?
btw, happy new year!
I seem to be running into this same issue. @paulcbetts or anyone else have an update? Thanks!
I have been running into this. I pushed a branch of my changes to make it work on osx: https://github.com/seancolyer/grunt-electron-installer/tree/fix-osx-build
General steps:
Squirrel.Windows
on Win 7 VM.Squirrel.Windows
with VS2015, it forced me to upgrade the project there to use the newer version. I think the project was built with VS2013.exe
's and added a couple of the other pdb
's in case valuable for debugging.template.nuspec
file in order to properly pickup *NIX style folders, and ignore files without extensions (which cause windows to vomit, there is probably a better fix here than ignoring these).Notes: My fixes would (I think) break compiling on Windows, so they should not be merged in to master as it stands.
This means that if you want to build on OSX you can check out my branch or do similar as needed. I'm not sure if this will help the core project here or not.
@seancolyer Your changes worked like a charm, thanks!
@seancolyer Installed master from npm and then replaced from your repo and worked. Thanks!
@seancolyer your fix works fine when i build the app the first time. When i try to build a new release without removing the old version an exception is thrown
System.DllNotFoundException: msdelta.dll
at (wrapper managed-to-native) DeltaCompressionDotNet.MsDelta.NativeMethods:CreateDelta (DeltaCompressionDotNet.MsDelta.FileTypeSet,long,long,string,string,string,string,DeltaCompressionDotNet.MsDelta.DeltaInput,intptr,DeltaCompressionDotNet.MsDelta.HashAlgId,string)
...
I'm not sure if this has something to do with your fix or if it is a general issue. Using your fix made it possible to build my app for windows on OSX for the first time
@paulcbetts Broken again, please see https://github.com/electron/windows-installer/issues/61, https://github.com/electron-userland/electron-builder/issues/294
I've created a setup.exe using grunt-electron-installer on osx, copied it to a windows machine and:
I use 2 npm scripts to build both windows versions:
And one more to call grunt-electron-installer:
Here's my gruntfile with options:
What's wrong? Setup didn't throw any error, just never launches.