electron-react-boilerplate / electron-react-boilerplate

A Foundation for Scalable Cross-Platform Apps
https://electron-react-boilerplate.js.org/
MIT License
23.3k stars 3.87k forks source link

Unresolved native module on electron build #1292

Closed kennir closed 7 years ago

kennir commented 7 years ago

My old issue #1290 was closed, I already build for windows binary on windows 10 32bit, can you take a look ?

https://github.com/kennir/electron-react-boilerplate.git

Thank you

kennir commented 7 years ago

I have try set env ELECTRON_BUILDER_ALLOW_UNRESOLVED_DEPENDENCIES=true then package again, then I got the package

electron-builder 19.42.2
⚠️  Unresolved node modules: printer
No native production dependencies                   <============= Why ?
⚠️  Packaging using asar archive is disabled — it is strongly not recommended.
Please enable asar and use asarUnpack to unpack files that must be externally available.
Packaging for win32 ia32 using electron 1.7.9 to release\win-ia32-unpacked
Building nsis installer (ia32)

But the exe throw a exception says can't find module 'printer'

Should I add node-loader ?

kennir commented 7 years ago

Now I can output electron-builder debug information, It's seems electron-builder can handle two package.json but still cannot find printer module which in app/package.json

 electron-builder Two package.json structure is used (dev: C:\Users\kenni\Developer\erp-printer\package.json, app: C:\U
ers\kenni\Developer\erp-printer\app\package.json) +1s
 electron-builder Unresolved dependencies after first round: printer +181ms
️  Unresolved node modules: printer
kennir commented 7 years ago

I found the solution! It seems a issue of electron-builder