search

electron-userland / devtron

[LOOKING FOR MAINTAINERS] An Electron DevTools Extension
https://electronjs.org/devtron
MIT License
1.73k stars 100 forks source link

[Security] Bump highlight.js from 9.18.5 to 11.0.1 #250

Closed dependabot-preview[bot] closed 3 years ago

dependabot-preview[bot] commented 3 years ago

Bumps highlight.js from 9.18.5 to 11.0.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

ReDOS vulnerabities: multiple grammars

Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)

oswasp:

> The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.

If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).

This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto to detect the language (and have any of these grammars registered) you are vulnerable.

All versions prior to 10.4.1 are vulnerable, including version 9.18.5.

Grammars with exponential backtracking issues:

  • c-like (c, cpp, arduino)
  • handlebars (htmlbars)
  • gams
  • perl
  • jboss-cli
  • r

... (truncated)

Affected versions: >= 9.0.0 < 10.4.1

Release notes

Sourced from highlight.js's releases.

Version 11

Potentially Breaking Changes

This is a major release. As such it contains breaking changes which may require action from users. Most of the breaking changes work was done by the current maintainer [Josh Goebel][] (ref: #2558) while many other contributors contributed many other changes for this release. You'll find that list below the breaking changes summary.

Please read VERSION_11_UPGRADE.md for a detailed summary of all breaking changes. The below list should only be considered to be a summary.

Deprecations / Removals / API Changes:

  • initHighlighting() and initHighlightingOnLoad() deprecated. Use highlightAll().
  • highlightBlock(el) deprecated. Use highlightElement(el)
  • before:highlightBlock & after:highlightBlock callbacks deprecated. Use equivalent highlightElement callbacks.
  • highlight(languageName, code, ignoreIllegals, continuation) signature deprecated. Use highlight(code, {language, ignoreIllegals}).
  • Deprecated highlight() signature no longer supports continuation argument.
  • tabReplace option removed. Consider a plugin.
  • useBR option removed. Consider a plugin or CSS.
  • requireLanguage() removed. Use getLanguage().
  • endSameAsBegin mode key removed. Use hljs.END_SAME_AS_BEGIN.
  • lexemes mode key removed. Use keywords.$pattern.
  • The return values/keys of some APIs have changed slightly.

Security:

  • HTML auto-passthru has been removed. Consider a plugin.
  • Unescaped HTML is now stripped (for security). A warning is logged to the console. (#3057) [Josh Goebel][]

Themes:

  • The default padding of all themes increases (0.5em => 1em).
  • schoolbook has been updated to remove the lined background.
  • github updated to better match modern GitHub (#1616) [Jan Pilzer][]
  • github-gist has been removed in favor of github [Jan Pilzer][]
  • Base16 named themes have been updated to their "canonical" versions
  • nnfx updated for v11 xml styles and improved css support

Language Grammars:

  • Default CDN build drops support for several languages.
  • Some language grammar files have been removed.
  • Some redundant language aliases have been removed.

Other changes

Parser:

  • enh(vala) improve language detection for Vala (#3195) [Konrad Rudolph][]
  • enh(r) add support for operators, fix number highlighting bug (#3194, #3195) [Konrad Rudolph][]
  • enh(parser) add beginScope and endScope to allow separate scoping begin and end (#3159) [Josh Goebel][]
  • enh(parsed) endScope now supports multi-class matchers as well (#3159) [Josh Goebel][]
  • enh(parser) highlightElement now always tags blocks with a consistent language-[name] class [Josh Goebel][]

... (truncated)

Changelog

Sourced from highlight.js's changelog.

Version 11.0.1

Version 11.0.0

This is a major release. As such it contains breaking changes which may require action from users. Please read VERSION_11_UPGRADE.md for a detailed summary of all breaking changes.

Potentially breaking changes

Unless otherwise attributed items below are thanks to Josh Goebel (ref: #2558).

The below list should only be considered to be a high-level summary.

Deprecations / Removals / API Changes:

  • initHighlighting() and initHighlightingOnLoad() deprecated. Use highlightAll().
  • highlightBlock(el) deprecated. Use highlightElement(el)
  • before:highlightBlock & after:highlightBlock callbacks deprecated. Use equivalent highlightElement callbacks.
  • highlight(languageName, code, ignoreIllegals, continuation) signature deprecated. Use highlight(code, {language, ignoreIllegals}).
  • Deprecated highlight() signature no longer supports continuation argument.
  • tabReplace option removed. Consider a plugin.
  • useBR option removed. Consider a plugin or CSS.
  • requireLanguage() removed. Use getLanguage().
  • endSameAsBegin mode key removed. Use hljs.END_SAME_AS_BEGIN.
  • lexemes mode key removed. Use keywords.$pattern.
  • The return values/keys of some APIs have changed slightly.

Security:

  • HTML auto-passthru has been removed. Consider a plugin.
  • Unescaped HTML is now stripped (for security). A warning is logged to the console. (#3057) Josh Goebel

Themes:

  • The default padding of all themes increases (0.5em => 1em).
  • schoolbook has been updated to remove the lined background.
  • github updated to better match modern GitHub (#1616) [Jan Pilzer][]
  • github-gist has been removed in favor of github [Jan Pilzer][]
  • Base16 named themes have been updated to their "canonical" versions
  • nnfx updated for v11 xml styles and improved css support

Language Grammars:

  • Default CDN build drops support for several languages.
  • Some language grammar files have been removed.

... (truncated)

Commits
  • 1cf31f0 (chore) release 11.0.1
  • fbf223a (fix) use console.log for .js.js deprecation warning
  • 9268dc2 (fix) do not restrict exports from cdn-assets
  • 2185721 bump for CDN redeploy
  • 0261c45 (chore) update browser tests
  • 1c7c696 (chore) bump some deps
  • 970a4d3 (fix) fire after:highlightElement after DOM is updated
  • 947e925 bump version to 11.0.0
  • 5dc5176 (chore) dual package (#3188)
  • 15ed6a4 enh(r) Add operators and punctuation (#3195)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by highlightjs_bot, a new releaser for highlight.js since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
dependabot-preview[bot] commented 3 years ago

Superseded by #257.