search

electron-userland / electron-builder-binaries

172 stars 60 forks source link

Update linux osslsigncode (1.7.1) #11

Closed yarcub closed 6 years ago

yarcub commented 6 years ago

Fixes #10 (Support MSI code signing in linux).

Based on https://github.com/sporsh/docker-osslsigncode/blob/master/Dockerfile It downloads osslsigncode source from sourceforge and builds the binary. The build script adds the local workdir as a volume and overrides the binary to commit. winCodeSign/linux/build.sh

Note: This version has libgsf linked as dependency to also support msi signing on linux.

For everyone wanting to sign msi on linux before this is merged, use the binary on this PR and override the signing tool location with the env vars:

USE_SYSTEM_SIGNCODE=false
ENV SIGNTOOL_PATH=${osslsigncode_location}
ewjordan commented 6 years ago

+1 on getting this reviewed and merged in - as I mention in https://github.com/code-dot-org/browser/pull/47, this workaround was necessary for me to create a signed MSI build on OS X via Docker.

develar commented 6 years ago

Thanks a lot that you provide infrastructure instead of just build files.

develar commented 6 years ago

libgsf linked as dependency

@yarcub Statically? Or libgsf-1-dev is required on user machine?

develar commented 6 years ago

osslsigncode-osslsigncode-e72a1937d1a13e87074e4584f012f13e03fc1d64.zip

develar commented 6 years ago

/home/develar/Desktop/osslsigncode: error while loading shared libraries: libgsf-1.so.114: cannot open shared object file: No such file or directory

So, need to figure out how to build statically.

develar commented 6 years ago

GSF_LIBS = -l:libgsf-1.a -lgobject-2.0 -lglib-2.0 -lxml2 -l:libz.a -l:libbz2.a is a solution. Once tests will be passed, I will release a new version of electron-builder.