search

electron-userland / electron-builder-binaries

172 stars 60 forks source link

feature: Adding nsis binaries with NSIS_CONFIG_LOG=yes #13

Closed shaluyadav13 closed 4 years ago

shaluyadav13 commented 6 years ago

Issue #12 Include the NSIS binaries build with scons NSIS_CONFIG_LOG=yes flag. So, that when needed logging capabilities can be switched on by setting LogSet on. NSIS Special build with logging: https://sourceforge.net/projects/nsis/files/NSIS%203/3.03/nsis-3.03-log.zip/

develar commented 6 years ago

Is this binaries has special long string support? strlen 8192?

shaluyadav13 commented 6 years ago

No, This build includes advanced logging features that allow you create an exact log of all installer actions. You can use it if you want testers or users to send installation reports. Build command is scons NSIS_CONFIG_LOG=yes PREFIX=C:\somewhere install-compiler install-stubs

shaluyadav13 commented 6 years ago

@develar Any update on this pull request?

develar commented 6 years ago

@shaluyadav13 Please compile with also NSIS_MAX_STRLEN=8192 and PR will be merged.

mweichert commented 5 years ago

Any update on when this will be merged?

BitPhoenix commented 5 years ago

Also interested in this as we would like to be able to during the NSIS install. Any update on when this will be merged?

phuonghuynh commented 5 years ago

+1

mengzhidiguo commented 5 years ago

Any update on when this will be merged?

Janealter commented 4 years ago

Any update?

Janealter commented 4 years ago

I made PR with NSIS_MAX_STRLEN=8192 https://github.com/electron-userland/electron-builder-binaries/pull/31