search

electron-userland / electron-builder-binaries

174 stars 60 forks source link

Add makepri.exe binaries for windows builds #3

Closed surajreddy closed 7 years ago

surajreddy commented 7 years ago

Hi folks,

I am looking into automating the addition of custom assets to electron-builder based on the steps described in https://github.com/electron-userland/electron-builder/issues/987#issuecomment-267406485

This requires the availability of the makepri windows binaries, and this is my attempt at adding them.

I copied the binaries from my local windows kit folder, from Windows Kits\10\bin\10.0.15063.0\x86 and Windows Kits\10\bin\10.0.15063.0\x64, respectively. Is this the best place to get these files?

Please let me know if I'm doing this right, or if I need to change anything.

Thanks!

develar commented 7 years ago

According to https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk, you have latest SDK, 👍

develar commented 7 years ago

Thanks, will be released soon.

surajreddy commented 7 years ago

whoa, that was lightning fast! Thank you!