electron-userland / electron-builder-binaries

172 stars 60 forks source link

How to update / upgrade NSIS #42

Open Simon-Laux opened 3 years ago

Simon-Laux commented 3 years ago

We have an issue where the installer is crashing sometimes (when the user directory contains spaces) before doing anything. https://github.com/deltachat/deltachat-desktop/issues/1269

I tried understanding the scripts but I currently don't have the time to find out how exactly everything works.

Can you describe what I need to do to make a build for or provide builds for:

I want to test if these new versions of NSIS can fix the issue.

mmaietta commented 3 years ago

I tried to figure this one out as well but didn't manage to get far on Windows. There are these scripts that have hints as to what needs to be done https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-prepare.sh https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis.sh https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-linux.sh

I could use an updated one for my PR adding debug logging to nsis installers https://github.com/electron-userland/electron-builder/pull/6024