search

electron-userland / electron-builder-binaries

172 stars 60 forks source link

Cannot use InstallLib in nsis #9

Open jkawamoto opened 6 years ago

jkawamoto commented 6 years ago

When I try to install a DLL by the following script in a custom NSIS script

!macro customInstall
    !include Library.nsh
    !define LIBRARY_X64
    !insertmacro InstallLib REGDLL NOTSHARED REBOOT_NOTPROTECTED $BUILD_RESOURCES_DIR/somelib.dll $SYSDIR\somelib.dll $SYSDIR
!macroend

I got the following error 

Error output:
sh: LibraryLocal: command not found

Looking for electron-builder-binaries/nsis/mac, actually there is no LibraryLocal, and also electron-builder-binaries/nsis/Bin/ doesn't have LibraryLocal.exe, too.

Could you please add LibraryLocal for all platforms?

develar commented 6 years ago

http://nsis-dev.github.io/NSIS-Forums/html/t-290288.html Hmmm.... Ok, I will investigate.

develar commented 6 years ago

Is it still actual?

jkawamoto commented 6 years ago

I got the above error when I tried to register DLLs and followed the instructions in https://stackoverflow.com/questions/47050866/nsis-register-dll-with-regsvr32

!include Library.nsh
!define LIBRARY_X64
!insertmacro InstallLib REGDLL NOTSHARED REBOOT_NOTPROTECTED c:\myfiles\64\dllname.dll $SYSDIR\dllname.dll $SYSDIR

After opening this issue, I moved the DLLs into another folder according to a comment on that page

I moved DLL into installation folder and it fixed that.

and it has worked for me so far.

I'm not sure but someone might have the same error if they tried to install DLLs in C:\Windows\system32.