search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.49k stars 1.72k forks source link

Effective configuration for CI builds #5403

Closed NullEnt1ty closed 3 years ago

NullEnt1ty commented 3 years ago

I was wondering why electron-builder does not write an effective configuration file when building the application using a CI platform. So I dug a bit in the source code and found this:

https://github.com/electron-userland/electron-builder/blob/d5d21da12f5efaf02659ce8d32c48440f6cf91ff/packages/app-builder-lib/src/packager.ts#L358-L362

Why on earth are you disabling this feature for CI builds? It is especially useful for CI builds to investigate failed builds. I couldn't find any reasoning for this so I'm hoping to get an answer here.

Thanks!

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

NullEnt1ty commented 3 years ago

Is this still relevant?

Yes.

Marantesss commented 5 months ago

Just came across this issue. I'm trying to build an electron app with Circle CI, but failing miserably.

The build works fine (at first glance), however: