search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.61k stars 1.74k forks source link

Missing files in resource folder (.e.g. files with .pyc extension) #6321

Closed centigrade-kdk closed 2 years ago

centigrade-kdk commented 2 years ago

Electron-Builder does not include all files into the resource folder according to the files property at package.json: build->files

The Following minimal example does not include dist/lib/abc.pyc

"files": [
      "dist/**/*",
    ],

After some poking around, I found the reason for the exclusion: The following variable used as an exclusion pattern is the reason.

https://github.com/electron-userland/electron-builder/blob/72ffc25063fc6d8f67e941ed7fc3b5991efb5448/packages/app-builder-lib/src/fileMatcher.ts#L22

https://github.com/electron-userland/electron-builder/blob/72ffc25063fc6d8f67e941ed7fc3b5991efb5448/packages/app-builder-lib/src/fileMatcher.ts#L182

I think that hardcoded remove pattern for these extensions should not be part of electon-builder or the user should at least have the possibility to override this.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.