electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.72k stars 1.74k forks source link

electron-updater on win32 downloads universal setup instead of arhitecture specific installer #6706

Open ferretwithaberet opened 2 years ago

ferretwithaberet commented 2 years ago

electron-updater downloads the universal installer instead of the architecture specific one(which is smaller in size). Is there any configuration I need to add to make it get the architecture specific one

mmaietta commented 2 years ago

I think it's hardcoded to look for universal. It doesn't know if there's arch-specific ones available nsis does support differential downloads though, so I think after you're on the current version, it'll be a differential download to the next universal update? https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/NsisUpdater.ts#L45-L47 I'm not familiar with this part of the updater

ferretwithaberet commented 2 years ago

I think it's hardcoded to look for universal. It doesn't know if there's arch-specific ones available nsis does support differential downloads though, so I think after you're on the current version, it'll be a differential download to the next universal update? https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/NsisUpdater.ts#L45-L47 I'm not familiar with this part of the updater

Isn't that for nsis-web, I am using the nsis target.

mmaietta commented 2 years ago

Ack, good callout. That's correct.

The original behavior was for electron-builder to only produce a single universal installer, that was what the electron-updater was designed around. A later feature request was to provide individual installers, but that logic isn't easily propagated to electron-updater