search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.73k stars 1.74k forks source link

Allow override `isSuitableWindowsTarget` for customized auto-updater #6967

Open haoxi911 opened 2 years ago

haoxi911 commented 2 years ago

On Windows, the app-update.yml and latest.yml files will only be created with nsis target, however, for those who are delivering portable Electron app, they won't be able to target to nsis, usually they will target to zip.

Even though electron-updater is not using Squirrel.Windows and won't be able to install the downloaded zip package, we as developers can create separate utility app to perform the installation (i.e. extract the zip to target folder).

isSuitableWindowsTarget method in PublishManager.ts prevents us from doing this level of customization. Maybe we should export this method so that people like me can override it from outside.

mmaietta commented 2 years ago

electron-updater is not using Squirrel.Windows and won't be able to install the downloaded zip package, we as developers can create separate utility app to perform the installation

Not sure how complex this would be, but would you be willing to contribute to electron-updater and add that functionality?

github-actions[bot] commented 1 day ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.