search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.59k stars 1.73k forks source link

Uninstaller fails to see app is already closed #7114

Closed NikhilNarayana closed 1 year ago

NikhilNarayana commented 2 years ago

The current version of my app fails to uninstall when upgrading because the uninstaller gets stuck thinking the app isn't closed even though it doesn't show up in Task Manager's details tab.

After a bit of finagling I managed to find that the new installer runs old-uninstaller.exe /KEEP_APP_DATA /allusers --updated _?=C:\Program Files\<app name>, but fails due to the mentioned issue. Removing --updated _?=C:\Program Files\<app name> from that command gets the uninstaller to complete , but that doesn't seem like the right solution nor does there seem to be an easy way to actually remove that argument from the uninstall call.

One of the goals of the update to my app is to upgrade to a newer electron-builder, where i've noticed this issue doesn't exist. I appreciate any insight I can get into this issue, thanks.

mmaietta commented 2 years ago

Hmmm. Not sure I can help you here... If you're unable to update the app due to a legacy version of electron-updater, then no matter of changes to the current electron-builder/updater will resolve that.

NikhilNarayana commented 2 years ago

Hmmm. Not sure I can help you here... If you're unable to update the app due to a legacy version of electron-updater, then no matter of changes to the current electron-builder/updater will resolve that.

I have found a patch that isn't ideal but does do the trick based on what I mentioned regarding _?=C:\Program Files\<app name>. I definitely don't consider this to be a true solution but it might have to do to ensure i can migrate my users.

https://github.com/project-slippi/slippi-launcher/commit/04fc7af34ee9074f76db8f3d40aed36bf4114b98

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 30 days with no activity.