Open tbhaxor opened 1 year ago
This *** is for security reason from github CI. They redact PII. I checked with
console.log(process.env.APPLE_ID === "doe@john.com@") // true
Note: You MUST specify APPLE_ID and APPLE_APP_SPECIFIC_PASSWORD via environment variables to activate notarization step
Note: You MUST specify APPLE_ID and APPLE_APP_SPECIFIC_PASSWORD via environment variables to activate notarization step
Can we re-open this, it is still not done on my end?
Do you want to use identifier
in electron build file?
Now getting error
Error: No authentication properties provided (e.g. appleId, appleApiKey)
I follow all the steps but I still get:
Error: No authentication properties provided (e.g. appleId, appleApiKey, keychain)
Sorry, this issue fell off my radar in my GH notifications list. This is the logic being used before calling the official npm electron/notarize
package. Hopefully this helps describe further what env vars are needed to activate the notarization integration.
https://github.com/electron-userland/electron-builder/blob/d5d9f3f9aaac0385cc943e30a0841669133afde8/packages/app-builder-lib/src/macPackager.ts#L532-L584
@Ladvace looks like your error may be coming from the electron/notarize package itself as I don't see that line logged anywhere in electron-builder. Can you please double-check the code linked above to make sure your env vars are set correctly? I'm wondering if we missed a verification edge case in the current notarization logic.
I think I probably called them in a different why, that's why, I'm gonna try renaming them asap:
APPLE_API_KEY
APPLE_API_KEY_ID
APPLE_API_ISSUER
actually another thing I got in before the error above is this one:
• skipped macOS notarization reason=
notarizeoptions were unable to be generated
is this something related or can I ignore it?
I'm currently using: electron-builder-notarize
@mmaietta I think I managed to do this, but for some reason now I'm getting this error:
⨯ Unexpected token 'E', "Error: The"... is not valid JSON failedTask=build stackTrace=SyntaxError: Unexpected token 'E', "Error: The"... is not valid JSON
SyntaxError: Unexpected token 'E', "Error: The"... is not valid JSON
at JSON.parse (<anonymous>)
those are the env I'm currently using:
APPLE_API_KEY_ID=MY_KEY
APPLE_API_ISSUER=MY_ISSUER_ID
APPLE_TEAM_ID=MY_TEAM_ID
APPLE_API_KEY=/Users/name/private_keys/AuthKey_MY_KEY.p8
PS: fixed following this: https://github.com/electron-userland/electron-builder/issues/8258
@mmaietta one problem I'm getting is, not sure why thi happens since I've set APPLE_API_ISSUER
Error: The appleApiIssuer property is required when using notarization with ASC credentials
managed to fix!, I think I didn't have to set notarize: true in the package.json since i'm using electron-builder-notarize
I am getting error in github CI, this how I am setting environment in build script
There is OTP on the login screen on web, could that be a reason, if yes how can i fix it?