search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.72k stars 1.74k forks source link

NSIS - MUI2: include nsh with MUI_PAGE_FINISH - Finish page comes before installation #7986

Open NicoLaval opened 10 months ago

NicoLaval commented 10 months ago 
I have the following simple nsh script I include in my build:

!include MUI2.nsh

!insertMacro MUI_PAGE_WELCOME
!insertMacro MUI_PAGE_DIRECTORY
!insertmacro MUI_PAGE_FINISH

The installer display the MUI_PAGE_FINISH before installing, when I press close button installation is made and that's it (installation is even good). I would like to order pages to have Welcome, Directory choice, pressing install and then having finish page.

Even if I had MUI_PAGE_INSTFILES:

!include MUI2.nsh

!insertMacro MUI_PAGE_WELCOME
!insertMacro MUI_PAGE_DIRECTORY
!insertmacro MUI_PAGE_INSTFILES
!insertmacro MUI_PAGE_FINISH

Same behaviour. Any idea?

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.