search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.63k stars 1.74k forks source link

Make the NSIS installer require Windows 10 if the Electron version is 23.0.0 or later #8088

Open NoahAndrews opened 7 months ago

NoahAndrews commented 7 months ago

Electron 23 removes support for Windows 7, 8, and 8.1. To prevent users of those operating systems from auto-updating to a version that won't run on their computer, electron-builder should build an NSIS installer that will refuse to run on those systems if the electron version is 23.0.0 or later. See the following code: https://github.com/electron-userland/electron-builder/blob/79df54238621fbe48ba20444129950ba2dc49983/packages/app-builder-lib/templates/nsis/common.nsh#L48-L55

NoahAndrews commented 7 months ago

While we're at it, we should also reject Windows Server 2012R2 and older.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

NoahAndrews commented 3 months ago

This still needs to happen. I've made a patch that works for my purposes, but it's not something that can be upstreamed as-is.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

NoahAndrews commented 1 month ago

I don't think this has happened yet