electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.47k stars 1.72k forks source link

`FlatpakOptions.files` has inconsistent type #8160

Open rotu opened 3 months ago

rotu commented 3 months ago

Type FlatpakOptions is incompatible with PlatformSpecificBuildOptions due to conflicting types of the files property.

PlatformSpecificBuildOptions: https://github.com/electron-userland/electron-builder/blob/8e36be113489c1afa6ce5ee6cdda73049bc619a6/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts#L53

whereas FlatpakOptions: https://github.com/electron-userland/electron-builder/blob/8e36be113489c1afa6ce5ee6cdda73049bc619a6/packages/app-builder-lib/src/options/linuxOptions.ts#L219-L224

These two objects are merged together in FlatpakTarget but the type incompatibility is obscured behind an as any cast.

https://github.com/electron-userland/electron-builder/blob/8e36be113489c1afa6ce5ee6cdda73049bc619a6/packages/app-builder-lib/src/targets/FlatpakTarget.ts#L12-L16

rotu commented 3 months ago

Found during development on macOS. I'm not sure the actual runtime implications of this since I'm not on Linux.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

rotu commented 1 month ago

not stale