search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.47k stars 1.72k forks source link

electron-updater and github provider doesn't work when files have spaces in them #8172

Open theogravity opened 3 months ago

theogravity commented 3 months ago

If my built app / package uses a space in the name, the resulting latest-mac.yml file will list the url with the appropriate spaces, eg My Application-v1-universal-mac.zip.

However, when using the github provider, the download will fail because when you publish files to github releases, they convert spaces to a period / dot, so the resulting download being offered from GH releases is actually My.Application-v1-universal-mac.zip.

The logic for reading the latest.yml / latest-<platform>.yml manifest needs to account for this behavior when using the github provider.

mlshv commented 3 months ago

I've noticed it too. Had to remove spaces from my app's name because of it

parz3val commented 2 months ago

This is because github replaces your space with ., Use '-' when you build your app and it'll work.

theogravity commented 2 months ago

This is because github replaces your space with ., Use '-' when you build your app and it'll work.

Doesn't help when the app name itself has spaces in it.

And yes, as noted in the issue you can work around it but it's not ideal.

parz3val commented 2 months ago

And yes, as noted in the issue you can work around it but it's not ideal.

I literally have the same issue. But I am only replacing the space in the name of installer not the app itself. And yes, I agree its not ideal.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.