search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.61k stars 1.74k forks source link

feat(appx): Update identityName for windows 10 #8206

Closed ifurther closed 3 months ago

ifurther commented 4 months ago
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 29b90b50cf624ab803ef3b764e75c647f7d4afc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------- | ----- | | app-builder-lib | Patch | | dmg-builder | Patch | | electron-builder-squirrel-windows | Patch | | electron-builder | Patch | | electron-forge-maker-appimage | Patch | | electron-forge-maker-nsis-web | Patch | | electron-forge-maker-nsis | Patch | | electron-forge-maker-snap | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
Latest commit 29b90b50cf624ab803ef3b764e75c647f7d4afc6
Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6663a70f7be51c0008ed4741
Deploy Preview https://deploy-preview-8206--car-park-attendant-cleat-11576.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ifurther commented 4 months ago

@mmaietta I updated the test file.

mmaietta commented 4 months ago

Looks like there's some compilation issues now:

Error: test/src/windows/appxTest.ts(58,9): error TS2353: Object literal may only specify known properties, and 'applicationId' does not exist in type 'WindowsConfiguration'.
ifurther commented 4 months ago

@mmaietta I removed it

ifurther commented 4 months ago

@mmaietta Sorry I find the error which is for loop logical.

ifurther commented 4 months ago

@mmaietta Sorry I fixed the if loop

ifurther commented 4 months ago

@mmaietta I check the applicationid and identityname rule and update it.

ifurther commented 4 months ago

@mmaietta I updated the replace and find number detection

ifurther commented 4 months ago

@mmaietta I found the error and updated it

ifurther commented 4 months ago

@mmaietta I found the error and updated it

mmaietta commented 3 months ago

Looking good! Left a minor comment about a more informative error message, other than that, this will be good to go 🙂

ifurther commented 3 months ago

Thank you