There is a build error when the configuration file on window is ts

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box

https://www.electron.build

MIT License

13.61k stars 1.74k forks source link

There is a build error when the configuration file on window is ts #8212

Closed just-ads closed 4 months ago

just-ads commented 4 months ago

Electron-Builder Version: ^24.13.3

Node Version: v20.11.0

Electron Version:^30.0.3
Electron Type (current, beta, nightly):current

Target: win

1715398025720

It may be because platform.name in defaultOutDir in the loadTSConfig file is not the correct value. It actually returns platform, and does not return win32 as expected. Should os.platform() be used?

mmaietta commented 4 months ago

Blocked by https://github.com/mighdoll/config-file-ts/pull/22

just-ads commented 4 months ago

Blocked by mighdoll/config-file-ts#22

config-file-ts Looks to have fixed this bug. Fixed platform selection in loadTsConfig.ts However, the read-config-file dependency used by electron-builder has not updated the config-file-ts dependency. This library seems to be unmaintained? It was last updated two years ago.

mmaietta commented 4 months ago

Looks like there's a dependency in between. I've opened up a PR with that project, read-config-file https://github.com/develar/read-config-file/pull/19