search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.46k stars 1.71k forks source link

feat(mac): support macos signature additionalArguments parameter #8218

Closed PBK-B closed 1 month ago

PBK-B commented 1 month ago

Update electron/osx-sign, add macos signing option additionalArguments. https://github.com/electron/osx-sign/pull/316 https://github.com/electron/osx-sign?tab=readme-ov-file#signing-with---deep

@develar @mmaietta TBR;

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 17fd5e56113e45fa657093b32d341a01c314356a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------- | ----- | | app-builder-lib | Major | | dmg-builder | Major | | electron-builder-squirrel-windows | Major | | electron-builder | Major | | electron-forge-maker-appimage | Major | | electron-forge-maker-nsis-web | Major | | electron-forge-maker-nsis | Major | | electron-forge-maker-snap | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
Latest commit 17fd5e56113e45fa657093b32d341a01c314356a
Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/664b691d1e83250008a083e0
Deploy Preview https://deploy-preview-8218--car-park-attendant-cleat-11576.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mmaietta commented 1 month ago

Thanks for your contribution! Could you please update electron/osx-sign package as part of the PR? Looks like we're pinned to 1.0.5

PBK-B commented 1 month ago

Oh, damn it, I forgot to submit the package.json file. Thank you for reminding me @mmaietta

PBK-B commented 1 month ago

Due to the higher pnpm version of the local environment, the pnpm-lock.yaml file has been greatly changed, so I choose to ignore the submission of the file (thus may lead to the failure of ci). If there is anything that can help, I can cooperate.

mmaietta commented 1 month ago

I gotcha. Updated the pnpm-lock.yaml and added a changeset