search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.61k stars 1.74k forks source link

Docs for `NotarizeNotaryOptions` stop mid-sentence #8230

Closed ferenc-a closed 1 week ago

ferenc-a commented 4 months ago

Here's the link: https://www.electron.build/configuration/mac.html#NotarizeNotaryOptions

And this is what is displayed. image

All instances of this sentence are somewhat different: https://github.com/search?q=repo%3Aelectron-userland%2Felectron-builder+%22The+team+ID+you+want+to+notarize+under+for+when+using%22&type=code

The one in scheme.json doesn't mention deprecation, and the one in mac.md is the one that stops mid-sentence, possibly because of faulty or obsolete auto-generation. The one at macOptions.ts seems to be the source of truth.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

ferenc-a commented 2 months ago

This is a minor issue, but still definitely not fixed. Is there a ticket tracking static docs generation that might relate to this?

mmaietta commented 2 months ago

There isn't a "central" ticket, but it's an issue I'm aware of. I intend on having the entire docs site (hopefully) redesigned to be more fluid and intuitive, as well as optimize the API doc generation that is current inter-spliced with static markdown doc content.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

mmaietta commented 1 week ago

Resolved: https://www.electron.build/mac#notarize