Keygen provider not working with target 'nsis-web'

[vincaslt]

• Electron-Builder Version: 24.13.3

• Node Version: v20.11.1

• Electron Version: 30.0.6
• Electron Type (current, beta, nightly): current

• Target: windows nsis-web

Keygen provider is not working with nsis-web target, the publishing process throws:

⨯ Not supported provider: keygen  failedTask=build stackTrace=Error: Not 
supported provider: keygen

Looking at the source code, it seems like keygen.sh provider is treated as S3-like download in computeDownloadUrl, but the actual base path resolution only supports "s3" and "spaces" providers: https://github.com/electron-userland/electron-builder/blob/77f977435c99247d5db395895618b150f5006e8f/packages/builder-util-runtime/src/publishOptions.ts#L384C3-L389C4

@ezekg would you know if keygen.sh is supposed to support nsis-web targets?

The electron-builder.yml file:

win:
  executableName: XXX
  target:
    - nsis-web
nsisWeb:
  artifactName: ${productName}-${version}-setup.${ext}
  shortcutName: ${productName}
  uninstallDisplayName: ${productName}
  createDesktopShortcut: always
  oneClick: false
  allowToChangeInstallationDirectory: true
publish:
  provider: 'keygen'
  account: '123'
  product: '123'
  channel: 'stable'

[ezekg]

I don't know enough about the nsis-web implementation to answer, but Keygen should be able to support anything the S3-compatible providers do since it uses S3 under the hood. @mmaietta?

[mmaietta]

Hmmm, I haven't seen this error before. Theoretically, nsis-web should work no differently than any of the other targets for publishing as they all use the same underlying logic. @vincaslt does this error appear for any other target, like nsis? Not sure how much time I have lately to investigate this further atm, but if you could post your logs with DEBUG=electron-builder, that might help me debug further from here

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 30 days with no activity.