search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.46k stars 1.71k forks source link

25.0.0-alpha.9 was released to npm as "latest" #8244

Closed AviVahl closed 3 weeks ago

AviVahl commented 1 month ago

The new version was released as "latest", overriding the previous "24.13.3"

$ npm dist-tags electron-builder
latest: 25.0.0-alpha.9
next: 25.0.0-alpha.8

can also be seen on: https://www.npmjs.com/package/electron-builder?activeTab=versions

leevva commented 3 weeks ago

Hi! When you fix this?

AviVahl commented 3 weeks ago

It can be easily fixed using https://docs.npmjs.com/cli/v10/commands/npm-dist-tag (has to be someone with publish access to the npm package)

lutzroeder commented 3 weeks ago

@mmaietta any insights if this was intentional or can be rolled back? An -alpha package is now marked as latest.

See #8241

mmaietta commented 3 weeks ago

Hmmmm, it should have occurred as the CI/CD has always published as next only. Just reset latest back to 24.13.3.

I'll look into the CI config, but it's already set to next https://github.com/electron-userland/electron-builder/blob/29f6504e181cef2c43ac070a80f24ee79dc52481/packages/electron-builder/package.json#L71-L73

Thank you all for calling this out!

lutzroeder commented 4 days ago

@mmaietta in #8253 same happened and electron-builder@25.0.0-alpha.10 is marked latest.

mmaietta commented 4 days ago

Oh gosh darn it. I'll fix that asap. Not sure why the automation isn't working correctly now despite no changes. Thanks for the quick heads up!

Honestly, I have this same automation setup in app-builder repo and it works exactly as prescribed -> publishes all new releases as next. IDK what's started happening here in this project since no CI/CD changes have occurred. I'll give it a go in updating pnpm and see if that resolves the issue