search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.46k stars 1.71k forks source link

fix: @electron/remote wrongly into Windows app.asar #8254

Closed beyondkmp closed 1 week ago

beyondkmp commented 3 weeks ago

Fix https://github.com/electron-userland/electron-builder/issues/8252

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: a97efec62ca1ca37a3b5314b44f775eac0b162cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------- | ----- | | app-builder-lib | Patch | | dmg-builder | Patch | | electron-builder-squirrel-windows | Patch | | electron-builder | Patch | | electron-forge-maker-appimage | Patch | | electron-forge-maker-nsis-web | Patch | | electron-forge-maker-nsis | Patch | | electron-forge-maker-snap | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 weeks ago

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
Latest commit a97efec62ca1ca37a3b5314b44f775eac0b162cc
Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/666e446626692a00084315e3
Deploy Preview https://deploy-preview-8254--car-park-attendant-cleat-11576.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

beyondkmp commented 3 weeks ago

@mmaietta I found a new bug. If a node module is aliased, it will cause the corresponding package in the ASAR file to be incorrect. Please help revivew: https://github.com/develar/app-builder/pull/119

beyondkmp commented 3 weeks ago

@mmaietta It seems like the CI has a cache, comparing with the previous snapshot. Often, the first run fails, and then it succeeds on a rerun without any changes. I haven't found the root cause yet.

mmaietta commented 2 weeks ago

@beyondkmp thank you! Reran the CI and it all passes, I'm not sure re: the caching issue but it is indeed leading to a flaky CI (which needs fixing for sure)

Does this PR depend on a release of the app-builder-bin changes as well?

beyondkmp commented 2 weeks ago

There's no interdependency.

beyondkmp commented 1 week ago

@mmaietta Please help rerun the failed job.