electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.46k stars 1.71k forks source link

Allow "compression" parameter for nsis/portable on win32 #8261

Open mydevpeeps opened 2 weeks ago

mydevpeeps commented 2 weeks ago

Environment

Details

Currently it is only possible to set compression to store on a "win" target. When building NSIS targets it is not possible to set this in the config as the builder errors out with it being an invalid option.

I think this option will help with development cycles and especially while developers are getting used to all the settings to test.

Testing

I tested hardcoding -mx=0 and -mmt=on inside app-builder-lib's out/targets/archive.js and saw the time it was taking to build my test NSIS build decrease by more than 50%, sometimes 70%. Further the size difference for my basic build was 119MB vs. 123MB so there wasn't much to gain there in my case. I could not get this to do the same with portable.

mydevpeeps commented 2 days ago

?