electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.46k stars 1.71k forks source link

fix: don't log ignored error when requiring custom publisher #8267

Closed George-Payne closed 1 week ago

George-Payne commented 2 weeks ago

When using a custom publish provider, it is first attempted to be imported from the build resources, then if that fails, it attempts to import it from node_modules.

Currently, if the first attempted path fails, it logs the error to the console.

image

This happens multiple times per publish, and adds a lot of noise to the output.

Considering it's a (possibly) expected error, it would be better to move this to a debug log, with explanation.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 318cdd5517a0854e0d6395e301a6a0154b8f5912

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------- | ----- | | app-builder-lib | Patch | | dmg-builder | Patch | | electron-builder-squirrel-windows | Patch | | electron-builder | Patch | | electron-forge-maker-appimage | Patch | | electron-forge-maker-nsis-web | Patch | | electron-forge-maker-nsis | Patch | | electron-forge-maker-snap | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
Latest commit 318cdd5517a0854e0d6395e301a6a0154b8f5912
Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/667affc117bae900088db6a3
Deploy Preview https://deploy-preview-8267--car-park-attendant-cleat-11576.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.