Open beyondkmp opened 4 days ago
Latest commit: 65d5bd067355ff715f1d59bbe81de1bfc716073b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 65d5bd067355ff715f1d59bbe81de1bfc716073b |
Latest deploy log | https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/668040c66b59ee0008dbbee4 |
Deploy Preview | https://deploy-preview-8282--car-park-attendant-cleat-11576.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Here's a minimal example, with an 'aborted' event. However, I'm currently not sure why this event isn't documented.
// test.js
'use strict';
// The same issue occurs with `http`, too.
const https = require('https');
const req = https.request('https://nodejs.org/dist/v13.7.0/node-v13.7.0.tar.gz');
req.on('response', (res) => {
res.on('aborted', () => console.log('aborted'))
res.on('abort', () => console.log('abort'))
setTimeout(() => {
console.log('start');
req.abort();
}, 500);
});
req.end();
Okay, that's super weird indeed. Thanks for the test script! Maybe we should have both listeners (just in case for backward compatibility)?
Any chance you'd be willing to post a screenshot of what error you're seeing in Sentry?
@mmaietta Here's the detailed sentry error. Because we recently enabled differential udpate, such errors have increased, so I suspect there is a connection here.
Any chance you'd be willing to test this on your app locally using patch-package first? I don't immediately see any harm/side-effects in the changes in this PR, but I don't have a way to verify locally via unit tests AFAICT.
Unfortunately, I cannot reproduce this issue locally at the moment. It only seems to occur frequently in production when there is a large user base. I'll have to wait for production to test it out.
There are many SimpleURLLoaderWrapper server error in sentrty, I think they might be caused by this event.
Here's a simple example: