search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.61k stars 1.74k forks source link

feat: add MemoLazy to fix codeSigningInfo not responding to changed args #8291

Closed IsaacAderogba closed 3 months ago

IsaacAderogba commented 3 months ago

Designed to fix the issue with codeSigningInfo not working when both mac.cscLink and mas.cscLink are defined with separate values. It currently only creates the codeSigningInfo value once and then reuses that across all other targets. Outlined here https://github.com/electron-userland/electron-builder/issues/8280.

A simpler approach would be to stop wrapping the execution of codeSigningInfo within the Lazy class, but this PR tries to preserve most of the existing behaviour.

Please close/ignore this if you deem it is working as intended. I can otherwise use patch-package to fix this, without maintaining a forked repo.

Thanks for your time!

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: edcbc69ab1f99f51b8dbecb12d0ccca7965d53ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
Latest commit be8dbd54bdb11890897e53884c51caa89ca03345
Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66888824c9d79500088fbe5b
Deploy Preview https://deploy-preview-8291--car-park-attendant-cleat-11576.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mmaietta commented 3 months ago

Made some minor modifications, such as adding deep equals functionality via recursion and a unit test. Also updated winPackager csc signing logic to use the MemoLazy class now since I think it'll run into the same issue when having multiple Window targets. Largest changes in the PR are just from regenerating the API docs.

Figured we could merge this in to resolve the issue and once the upstream PR is accepted, we can remove the local MemoLazy in favor of upstream.