search

electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.61k stars 1.74k forks source link

QUESTION: Do channels support *-alpha.1 *-alpha.2, or are they limited to *-alpha? #8500

Open rathboma opened 2 weeks ago

rathboma commented 2 weeks ago

Hey folks,

Quick question:

  1. The docs only provide examples using the syntax 1.0.0-alpha for an alpha build (docs link).
  2. Various issues suggest that syntax such as 1.0.0-alpha.1 is also supported

Can I ask for clarity on which it is? Happy to make a PR for the docs once I understand how it works.

Thanks!

mmaietta commented 2 weeks ago

Looks like the version is supported for being parsed https://www.electron.build/app-builder-lib.interface.platformspecificbuildoptions#detectupdatechannel

But the update channel will be parsed as alpha without the version number https://github.com/electron-userland/electron-builder/blob/4cacee4d63ebfc9aacf156bd8b7faa80be1325dc/packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts#L168-L172 https://github.com/electron-userland/electron-builder/blob/4cacee4d63ebfc9aacf156bd8b7faa80be1325dc/packages/app-builder-lib/src/publish/updateInfoBuilder.ts#L41-L63

DanielMcAssey commented 1 day ago

@mmaietta is the authority on this, but thought I would throw in my 2 pence. We have been using -alpha.2 -beta.14, etc for a good while now in production with many users, and updates have worked flawlessly (We use S3)