electron-userland / electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box
https://www.electron.build
MIT License
13.62k stars 1.74k forks source link

Regression in nsis-web target for `appPackageUrl` option #8581

Open grovesNL opened 1 day ago

grovesNL commented 1 day ago

Since #6964 the appPackageUrl doesn't work as intended because extra paths are appended to the URL, which means it's not possible to download the latest at a single URL (see #7732 for an example).

My understanding is that APP_PACKAGE_URL_IS_INCOMPLETE intentionally tried to skip setting the package name based on architecture, instead using the name specified with appPackageUrl, but #6964 will use the regular naming.

mmaietta commented 1 day ago

Would you mind sharing a minimum reproducible repo/gist for this issue? I'd like to create a unit test for this

Re: the PR, I'm wondering if it's just safer to revert, but I'd still like to do the unit test to prevent future regressions.