search

electron-userland / electron-compile

DEPRECATED: Electron supporting package to compile JS and CSS in Electron applications
1.01k stars 99 forks source link

TypeScript declarations (approx) based on the documentation #219

Closed danielearwicker closed 7 years ago

danielearwicker commented 7 years ago

Suggestion: include type declarations in the library itself.

These are just a starting point but should be better than nothing - I just worked from what I found in the docs, plus a few other things I clarified from reading the source. A major gap is the type CompilerBase which I can't find docs for or a central definition of what it should contain.

anaisbetts commented 7 years ago

This is a great PR, but I'm actually going to convert electron-compile to TypeScript soon, so we're gonna get this for free. I'll merge it in the interim tho!

danielearwicker commented 7 years ago

Awesome, that was going to be my next suggestion! :) By far the best way to ensure correct typings.

mariusschulz commented 7 years ago

Yey, that's great news! :)