Adding new '?from=FileFormat' support for .css protocol hooks

electron-userland / electron-compile

DEPRECATED: Electron supporting package to compile JS and CSS in Electron applications

1.01k stars 99 forks source link

Adding new '?from=FileFormat' support for .css protocol hooks #319

Closed carlrabbit closed 5 years ago

carlrabbit commented 5 years ago

Hi, I was running into an issue with recent (over a year?!) versions of electron-compile.

I thought that allowing (and parsing) query-string parameters is the best solution to the problem of the electron JS engine not allowing stylesheet-includes with a different file name than '.css' anymore.

If this solution is accepted, I would update the docs accordingly as well. Plus I would try to trigger updates in projects using us.

Kind regards, Martin

carlrabbit commented 5 years ago

Hi,

the PR check seems to fail not because of my changes. Looks like the latest tests are broken?!

How do we proceed from here?

KR, Martin

carlrabbit commented 5 years ago

Sorry, this was messed up as I started reusing my repo.