search

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

Update HTML compiler to use Pug #34

Open Xinayder opened 8 years ago

Xinayder commented 8 years ago

The update will allow the compiler to use Pug to compile and render .jade and .pug files.

I'm not sure if I've done it correctly, as I couldn't find a way to test the changes. I think that a PR will be required to reflect these changes on electron-compile.

anaisbetts commented 8 years ago

Why are we using an alpha version?

Xinayder commented 8 years ago

It's the latest version available on npm. When I tried installing the 1.11.0 version npm said it couldn't locate it.

Tag history: https://github.com/pugjs/pug/tags

anaisbetts commented 8 years ago

Hm, it might be better to hold off on this until a final version is released

Lichtjaeger commented 7 years ago

There are also some breaking changes between Jade v1 and Pug v2. It would be better to handle them separated until Jade support can be removed.

jacobq commented 6 years ago

It's been over a year now, so I suspect that there should be a straight-forward migration path to dropping jade in favor of pug. What needs to be done? Can I help? Should either this PR or #66 be closed in favor of the other or are they truly distinct?