electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

WIP: Recompile Less when dependent files (@imports) change #38

Closed mnquintana closed 7 years ago

mnquintana commented 8 years ago

⚠️ Work in progress ⚠️

Part of https://github.com/electron/electron-compile/issues/27

This PR implements determineDependentFiles for Less, which should give electron-compile everything it needs to know to properly recompile a Less file's dependencies. ✨

TODO

anaisbetts commented 8 years ago

Figure out how best to express the dependency between compile and determineDependentFiles (ie. determineDependentFiles must be called before compile)

The order methods are called during compilation are guaranteed by electron-compile, you don't have to worry about compile being called before determineDependentFiles

mnquintana commented 8 years ago

@paulcbetts Not in this second case:

Right now it's handled in CompilerHost, BUT it's possible for a compiler to require other compilers directly, like InlineHtml does, in which case we currently have to duplicate the logic

anaisbetts commented 7 years ago