electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 52 forks source link

Do not force override TypeScript outDir #41

Closed kwonoj closed 8 years ago

kwonoj commented 8 years ago

This PR removes force override to outDir of TypeScript compiler options to allow correct compilation emit for relative reference to internal modules.

Let's say folder structures

--app
    |--src
         |--utils
         |    +app-id.ts
         +logger.ts

and app-id.ts refer internal module logger as

import {logger} from '../logger';

logger.doSomething();

Then TypeScript compiler calculates output path unexpectedly, like

/logger.js
/app/app-id.js

makes typescript-simple fails to lookup emitted output. I don't have concrete explanation why path resolving works in those way though.