search

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

Passthrough text/css #42

Closed simongregory closed 7 years ago

simongregory commented 7 years ago

This fixes electron-compile#123

simongregory commented 7 years ago

Whilst this may fix the specific problem of text/css files not getting passed through it looks as though there's a wider issue to solve. In my case application/dash+xml fail in the same way, first attempt is going to be to setup the fallbackCompiler to handle anything unknown but I can't help thinking there's a better way to be doing this.

zeke commented 7 years ago

This seems fine, but is there an automated way to test it?

mnquintana commented 7 years ago

Will this break Less compilation? I think we might wanna re-work the MIME type for Less anyway (since it's set to text/css right now too)

michaelenger commented 7 years ago

@mnquintana Doesn't the compiler look for the text/less mimetype? https://github.com/electron/electron-compilers/blob/c662baa5e55487bc119eb20d42619339f6929391/src/css/less.js#L4

anaisbetts commented 7 years ago

This should already be fixed, if not please reopen!