search

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

fix(TypeScriptCompiler): do not process compiler if not exists #53

Closed kwonoj closed 7 years ago

kwonoj commented 7 years ago

This PR adds handlings to avoid compiler fails if TypeScript did not installed for any cases. And also revert compiler dependency to dependency instead of peerDep which makes compiler optional, to avoid regressions in #52.

malept commented 7 years ago

This appears to work for me, given the repro steps in #52.

anaisbetts commented 7 years ago

I don't think it's a good idea to nerf the compiler, I think we just need to ditch peerDep

kwonoj commented 7 years ago

@paulcbetts I'm ok with either, feel freely close PR as needed.

anaisbetts commented 7 years ago

❇️