search

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

add pug support #66

Open Sys0MKNR opened 7 years ago

Sys0MKNR commented 7 years ago

This pull adds pug support. It is kept in a seperate file to make the process of removing jade easier. If this pull gets accepted also my pull in the electron/electron-compile repo needs to be accepted to enable pug support. This just adds 'text/pug': 'pug' to the typesToRig object in src/rig-mime-types.js.

naderm commented 7 years ago

Bumping this!

The current jade version relies on an old version of uglify-js that is vulnerable to the security exploit CVE-2015-8857

(jade@^1.11.0 > transformers@^2.1.0 > uglify-js@~2.2.5)

graup commented 7 years ago

+1 What do we need to do to get this merged?

j-fan commented 6 years ago

Would also like to see this merged :)

Tenrys commented 6 years ago

Isn't jade a little bit outdated since the rename? Would be nice to finally be able to use pug instead.